Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependency): add explicit dependency of jaxb-api while upgrading spring boot 2.6.x #1205

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

j-sandy
Copy link
Contributor

@j-sandy j-sandy commented Dec 20, 2023

While upgrading spring boot 2.6.15, encounter below errors in igor-monitor-travis module during build:

/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Build.java:26: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Build.java:38: error: cannot find symbol
@XmlRootElement(name = "builds")
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Branch.java:22: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Branch.java:30: error: cannot find symbol
@XmlRootElement(name = "branch")
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Commit.java:26: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Commit.java:34: error: cannot find symbol
@XmlRootElement(name = "commit")
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Repository.java:21: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Repository.java:26: error: cannot find symbol
@XmlRootElement(name = "repository")
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/AccessToken.java:22: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/AccessToken.java:27: error: cannot find symbol
@XmlRootElement
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Builds.java:23: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Builds.java:24: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Builds.java:29: error: cannot find symbol
@XmlRootElement
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Build.java:27: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Build.java:33: error: cannot find symbol
@XmlRootElement(name = "builds")
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Builds.java:24: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Builds.java:25: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Builds.java:31: error: cannot find symbol
@XmlRootElement
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Job.java:23: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Job.java:29: error: cannot find symbol
@XmlRootElement(name = "job")
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Commit.java:24: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Commit.java:30: error: cannot find symbol
@XmlRootElement(name = "commits")
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/EmptyObject.java:20: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/EmptyObject.java:22: error: cannot find symbol
@XmlRootElement
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Jobs.java:24: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Jobs.java:25: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Jobs.java:31: error: cannot find symbol
@XmlRootElement
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Builds.java:35: error: cannot find symbol
  @XmlElement(name = "builds", required = false)
   ^
  symbol:   class XmlElement
  location: class V3Builds
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Builds.java:33: error: cannot find symbol
  @XmlElement(name = "builds", required = false)
   ^
  symbol:   class XmlElement
  location: class Builds
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Builds.java:37: error: cannot find symbol
  @XmlElement(name = "jobs", required = false)
   ^
  symbol:   class XmlElement
  location: class Builds
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Builds.java:41: error: cannot find symbol
  @XmlElement(name = "commits", required = false)
   ^
  symbol:   class XmlElement
  location: class Builds
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Jobs.java:35: error: cannot find symbol
  @XmlElement(name = "jobs", required = false)
   ^
  symbol:   class XmlElement
  location: class V3Jobs
32 errors
startup failed:
Compilation failed; see the compiler error output for details.

1 error

> Task :igor-monitor-travis:compileGroovy FAILED

To fix these issues, adding explicit dependency of jaxb-api in igor-monitor-travis.gradle. Since jaxb-api is a transitive dependency of spring boot both 2.5.x and 2.6.x, pinning the dependency is not required.

…g spring boot 2.6.x

While upgrading spring boot 2.6.15, encounter below errors in igor-monitor-travis module during build:
```
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Build.java:26: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Build.java:38: error: cannot find symbol
@XmlRootElement(name = "builds")
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Branch.java:22: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Branch.java:30: error: cannot find symbol
@XmlRootElement(name = "branch")
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Commit.java:26: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Commit.java:34: error: cannot find symbol
@XmlRootElement(name = "commit")
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Repository.java:21: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Repository.java:26: error: cannot find symbol
@XmlRootElement(name = "repository")
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/AccessToken.java:22: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/AccessToken.java:27: error: cannot find symbol
@XmlRootElement
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Builds.java:23: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Builds.java:24: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Builds.java:29: error: cannot find symbol
@XmlRootElement
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Build.java:27: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Build.java:33: error: cannot find symbol
@XmlRootElement(name = "builds")
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Builds.java:24: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Builds.java:25: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Builds.java:31: error: cannot find symbol
@XmlRootElement
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Job.java:23: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Job.java:29: error: cannot find symbol
@XmlRootElement(name = "job")
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Commit.java:24: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Commit.java:30: error: cannot find symbol
@XmlRootElement(name = "commits")
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/EmptyObject.java:20: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/EmptyObject.java:22: error: cannot find symbol
@XmlRootElement
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Jobs.java:24: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Jobs.java:25: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
                                ^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Jobs.java:31: error: cannot find symbol
@XmlRootElement
 ^
  symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Builds.java:35: error: cannot find symbol
  @xmlelement(name = "builds", required = false)
   ^
  symbol:   class XmlElement
  location: class V3Builds
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Builds.java:33: error: cannot find symbol
  @xmlelement(name = "builds", required = false)
   ^
  symbol:   class XmlElement
  location: class Builds
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Builds.java:37: error: cannot find symbol
  @xmlelement(name = "jobs", required = false)
   ^
  symbol:   class XmlElement
  location: class Builds
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Builds.java:41: error: cannot find symbol
  @xmlelement(name = "commits", required = false)
   ^
  symbol:   class XmlElement
  location: class Builds
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Jobs.java:35: error: cannot find symbol
  @xmlelement(name = "jobs", required = false)
   ^
  symbol:   class XmlElement
  location: class V3Jobs
32 errors
startup failed:
Compilation failed; see the compiler error output for details.

1 error

> Task :igor-monitor-travis:compileGroovy FAILED
```

So, adding explicit dependency of jaxb-api in igor-monitor-travis.gradle. Since jaxb-api is a transitive dependency of [spring boot](https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/2.6.15/spring-boot-dependencies-2.6.15.pom) both 2.5.x and 2.6.x, pinning the dependency is not required.
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Dec 20, 2023
@mergify mergify bot added the auto merged label Dec 20, 2023
@mergify mergify bot merged commit c734a32 into spinnaker:master Dec 20, 2023
5 checks passed
@j-sandy j-sandy deleted the jaxb-api-dep branch December 21, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants