refactor(StashClient,WerckerClient): separate catch blocks for Spinna…

…kerNetworkException for readability
spinnaker · Sep 11, 2023 · 3cee198 · 3cee198
1 parent 323f19f
commit 3cee198
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 15 deletions.
diff --git a/igor-web/src/main/groovy/com/netflix/spinnaker/igor/scm/stash/CommitController.groovy b/igor-web/src/main/groovy/com/netflix/spinnaker/igor/scm/stash/CommitController.groovy
@@ -46,16 +46,21 @@ class CommitController extends AbstractCommitController {
         CompareCommitsResponse commitsResponse
         try {
             commitsResponse = stashMaster.stashClient.getCompareCommits(projectKey, repositorySlug, requestParams)
-        }  catch (SpinnakerServerException e) {
-            if (e instanceof  SpinnakerNetworkException) {
-                throw new NotFoundException("Could not find the server ${stashMaster.baseUrl}")
-            } else if (e instanceof  SpinnakerHttpException && ((SpinnakerHttpException)e).getResponseCode() == 404) {
+        }   catch (SpinnakerNetworkException e) {
+          throw new NotFoundException("Could not find the server ${stashMaster.baseUrl}")
+        } catch  (SpinnakerHttpException e) {
+          if(e.getResponseCode() == 404) {
                 return getNotFoundCommitsResponse(projectKey, repositorySlug, requestParams.to, requestParams.from, stashMaster.baseUrl)
-            }
-            log.error(
+          }
+          log.error(
                 "Failed to fetch commits for {}/{}, reason: {}",
                 projectKey, repositorySlug, e.message
             )
+        }catch  (SpinnakerServerException e) {
+          log.error(
+            "Failed to fetch commits for {}/{}, reason: {}",
+            projectKey, repositorySlug, e.message
+          )
         }
 
         List result = []

diff --git a/igor-web/src/main/groovy/com/netflix/spinnaker/igor/scm/stash/client/StashMaster.groovy b/igor-web/src/main/groovy/com/netflix/spinnaker/igor/scm/stash/client/StashMaster.groovy
@@ -35,10 +35,10 @@ class StashMaster extends AbstractScmMaster {
   List<String> listDirectory(String projectKey, String repositorySlug, String path, String ref) {
     try {
       return stashClient.listDirectory(projectKey, repositorySlug, path, ref).toChildFilenames()
-    } catch (SpinnakerServerException e) {
-      if (e instanceof  SpinnakerNetworkException) {
-        throw new NotFoundException("Could not find the server ${baseUrl}")
-      }
+    }catch (SpinnakerNetworkException e) {
+      throw new NotFoundException("Could not find the server ${baseUrl}")
+    }
+    catch (SpinnakerServerException e) {
       log.error(
         "Failed to fetch file from {}/{}/{}, reason: {}",
         projectKey, repositorySlug, path, e.message
@@ -61,10 +61,9 @@ class StashMaster extends AbstractScmMaster {
         contents += response.toTextContents() + "\n"
       }
       return contents
-    }  catch (SpinnakerServerException e) {
-      if (e instanceof SpinnakerNetworkException) {
-        throw new NotFoundException("Could not find the server ${baseUrl}")
-      }
+    } catch (SpinnakerNetworkException e) {
+      throw new NotFoundException("Could not find the server ${baseUrl}")
+    } catch(SpinnakerServerException e) {
       log.error(
         "Failed to fetch file from {}/{}/{}, reason: {}",
         projectKey, repositorySlug, path, e.message

diff --git a/igor-web/src/main/groovy/com/netflix/spinnaker/igor/wercker/WerckerBuildMonitor.groovy b/igor-web/src/main/groovy/com/netflix/spinnaker/igor/wercker/WerckerBuildMonitor.groovy
@@ -183,7 +183,7 @@ class WerckerBuildMonitor extends CommonPollingMonitor<PipelineDelta, PipelinePo
                     ))
         } catch (e) {
             log.error("Error processing runs for [{}:{}]", kv("master", master), kv("pipeline", pipeline), e)
-            if (e.getCause() instanceof SpinnakerServerException) {
+            if (e instanceof SpinnakerServerException) {
                 def re = (SpinnakerServerException) e.getCause()
                 def url = null
                 if (re instanceof  SpinnakerHttpException){