refactor(travisService): remove try-catch since e.getBodyAs() is no l…

…onger called
spinnaker · Sep 12, 2023 · 131bd89 · 131bd89
1 parent 9f17d8b
commit 131bd89
Showing 1 changed file with 9 additions and 16 deletions.
diff --git a/...monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/service/TravisService.java b/...monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/service/TravisService.java
@@ -446,22 +446,15 @@ private Optional<String> getAndCacheJobLog(int jobId) {
       }
     } catch (SpinnakerServerException e) {
       if (e instanceof SpinnakerHttpException) { // only SpinnakerHttpException has a response body
-        try {
-          Map<String, Object> body = ((SpinnakerHttpException) e).getResponseBody();
-          if (body != null && "log_expired".equals(body.get("error_type"))) {
-            log.info(
-                "{}: The log for job id {} has expired and the corresponding build was ignored",
-                groupKey,
-                jobId);
-          } else {
-            log.warn(
-                "{}: Could not get log for job id {}. Error from Travis:\n{}",
-                groupKey,
-                jobId,
-                body);
-          }
-        } catch (RuntimeException ex) {
-          log.warn("{}: Could not parse original error message from Travis", groupKey, ex);
+        Map<String, Object> body = ((SpinnakerHttpException) e).getResponseBody();
+        if (body != null && "log_expired".equals(body.get("error_type"))) {
+          log.info(
+              "{}: The log for job id {} has expired and the corresponding build was ignored",
+              groupKey,
+              jobId);
+        } else {
+          log.warn(
+              "{}: Could not get log for job id {}. Error from Travis:\n{}", groupKey, jobId, body);
         }
       }
     }