Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tox. #68

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add tox. #68

wants to merge 5 commits into from

Conversation

JulienPalard
Copy link
Collaborator

No description provided.

tox.ini Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
sphinxlint/__main__.py Outdated Show resolved Hide resolved
@JulienPalard
Copy link
Collaborator Author

JulienPalard commented Jul 24, 2023

With the "better" detection of tables I had to remove a test that was passing by chance: the test was ensuring we were finding errors in a table... and the table used in the test was so small it went undetected by the old check, so we were looking for errors in it. With the current detection of table we correctly identify the table as a table and stop searching in it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, if tox is added, shall also be used in CI so we keep them aligned?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #100.

There's some non-tox things added in this PR. If they're still needed, should this PR be rebased. or this closed and those bits split out?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split make sense to me...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, how about trying tox-gh see #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants