Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faulty buffer write operations #52

Open
BridgeAR opened this issue Feb 14, 2018 · 1 comment
Open

Faulty buffer write operations #52

BridgeAR opened this issue Feb 14, 2018 · 1 comment

Comments

@BridgeAR
Copy link

BridgeAR commented Feb 14, 2018 •
edited
Loading

Right now the framer has multiple buffer.writeUInt32BE calls. In case priority.exclusive is truthy it can pass in a negative value because 0x80000000 | undefined === -(2 ** 31).

This currently works because the buffer write operation will overflow and safe that value. That will not be possible in future versions anymore.

Right now the test should generate priority request frame will result in such a case. I tried to fix it but I am not sure what the right solution should be. Ping @indutny

Refs: nodejs/node#18395
@BridgeAR
Copy link
Author

BridgeAR commented Apr 1, 2018

Ping

@BridgeAR BridgeAR mentioned this issue Apr 29, 2018
Closed
@BridgeAR BridgeAR mentioned this issue May 20, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BridgeAR