Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current failures on master #558

Closed
targos opened this issue Apr 6, 2018 · 4 comments
Closed

Current failures on master #558

targos opened this issue Apr 6, 2018 · 4 comments

Comments

@targos
Copy link
Member

targos commented Apr 6, 2018

uglify-js

Fails only with NODE_PENDING_DEPRECATION=1

error:                       | 1) bin/uglifyjs Should warn for missing inline source map:                                                                                                                                                    
error:                       |                                                                                                                                                                                                               
error:                       | Uncaught AssertionError [ERR_ASSERTION]: 'WARN: inline source map not found\n(node:1979) [DEP0005] DeprecationWarning: The Buffer() and new Buffer() constructors are ... === 'WARN: inline source map not found\n'
error:                       | + expected - actual                                                                                                                                                                                           
error:                       |                                                                                                                                                                                                               
error:                       | WARN: inline source map not found                                                                                                                                                                             
error:                       | -(node:1979) [DEP0005] DeprecationWarning: The Buffer() and new Buffer() constructors are not recommended for use due to security and usability concerns. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffe
error:                       |                                                                                                                                                                                                               
error:                       | at test/mocha/cli.js:239:20                                                                                                                                                                                   
error:                       | at ChildProcess.exithandler (child_process.js:265:7)                                                                                                                                                          
error:                       | at maybeClose (internal/child_process.js:936:16)                                                                                                                                                              
error:                       | at Process.ChildProcess._handle.onexit (internal/child_process.js:220:5)                                                                                                                                      
error:                       |                                                                                                                                                                                                               
error:                       |                                                                                                                                                                                                               
error:                       |                                                                                                                                                                                                               
error:                       |                                                                                                                                                                                                               
error:                       | (node:28568) [DEP0005] DeprecationWarning: The Buffer() and new Buffer() constructors are not recommended for use due to security and usability concerns. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffe
error:                       | (node:28589) [DEP0005] DeprecationWarning: The Buffer() and new Buffer() constructors are not recommended for use due to security and usability concerns. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffe
error:                       | npm ERR! Test failed.  See above for more details.                                                                                                                                                            
error:   done                | The smoke test has failed.

bcrypt

Depends on a too old version of NAN.
Opened kelektiv/node.bcrypt.js#588 to ask for a new publish with NAN >= 2.8.0.

weak

Fails with:

#
# Fatal error in ../deps/v8/src/keys.cc, line 481
# Check failed: element->ToUint32(&number).
#
Illegal instruction (core dumped)

Issue: TooTallNate/node-weak#87
To be investigated.

@targos
Copy link
Member Author

targos commented Apr 8, 2018

bcrypt is fixed with v2.0.0

@targos
Copy link
Member Author

targos commented Apr 8, 2018

New issue with spdy:

error:                       | 32 passing (242ms)
error:                       | 3 failing
error:                       |
error:                       | 1) SPDY Server h2 ssl mode should process GET request:
error:                       | Uncaught Frame length OOB
error:                       |
error:                       |
error:                       | 2) SPDY Server h2 ssl mode "after each" hook:
error:                       | Uncaught Error: socket hang up
error:                       | at TLSSocket.onclose (node_modules/spdy-transport/lib/spdy-transport/connection.js:181:15)
error:                       | at _handle.close (net.js:599:12)
error:                       | at TCP.done [as _onclose] (_tls_wrap.js:387:7)
error:                       |
error:                       | 3) SPDY Server h2 ssl mode "before each" hook for "should process GET request":
error:                       | TypeError: Cannot read property 'call' of undefined
error:                       |
error:                       |
error:                       |
error:                       |
error:                       | 4) "before each" hook for "should process GET request"
error:                       |
error:                       | npm ERR! Test failed.  See above for more details.
error:   done                | The smoke test has failed.

/cc @indutny

@BridgeAR
Copy link
Member

@targos the spdy issue is likely this one: spdy-http2/spdy-transport#52

The problem is that it is not really maintained anymore because of http2.

@al-k21
Copy link
Contributor

al-k21 commented Apr 30, 2018

The problem is that it is not really maintained anymore because of http2.

Should we still include spdy in the lookup if it is not maintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants