Limit code repetition in app/views.py
#441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hirumal Priyashan <[email protected]>
Signed-off-by: Hirumal Priyashan <[email protected]>
rtgdk
reviewed
Mar 12, 2023
Change function name to get_context_dict_for_license_xml from get_context_dict Signed-off-by: Hirumal Priyashan <[email protected]>
Signed-off-by: Hirumal Priyashan <[email protected]>
|
Overall LGTM @HirumalPriyashan . Thanks for working on this! Let's run tests on these change and post the screenshot. Will merge after that. |
rtgdk
approved these changes
Mar 12, 2023
|
Running all the tests through Have check which tests are depend on the changes and checked whether they are passing. |
|
Thanks @HirumalPriyashan for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this issue points out, there are redundant code segments in the
app/views.py. This PR will removes few redundant code segments from there.Additionally, have removed unused imports from
app/views.py.