You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since the license request and license namespace section of the SPDX online tools is quite similar in functionality. Both of these section provides the user the ability to submit license requests or license namespace, But to a different repository. Some of the code of namespaces is quite similar to that of license request, We could have easily adapted our code to use license request code to limit code repetition.
Code repetition means we will have to test that code as well, make changes at both the places, similar js files take up space, and load time it slows down the website due to more HTTP requests.
@rtgdk Hi, I was thinking about how to solve the similarity issue in script.js and ns_script.js --
Have 3 files, one holding the similar code and the other two holding the different code, and load two scripts each in editor.html and ns_editor.html.
Combine the two files into one and have if statements that control which functions to use for the normal script and the namespace script?
May I have your thoughts on these solutions? Is there one that would be preferable?
Thank you.
Since the license request and license namespace section of the SPDX online tools is quite similar in functionality. Both of these section provides the user the ability to submit license requests or license namespace, But to a different repository. Some of the code of namespaces is quite similar to that of license request, We could have easily adapted our code to use license request code to limit code repetition.
Code repetition means we will have to test that code as well, make changes at both the places, similar js files take up space, and load time it slows down the website due to more HTTP requests.
Some egs of code repetition-
spdx-online-tools/src/app/views.py
Line 1576 in 8d1d83b
spdx-online-tools/src/app/views.py
Line 1630 in 8d1d83b
script.js
andns_script.js
are quite similar.The text was updated successfully, but these errors were encountered: