feat: faster jsonification #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for robyn canceled.
|
sansyrox
force-pushed
the
feat/faster-jsonification
branch
from
00cf6c2
to
238577a
Compare
CodSpeed Performance ReportMerging #571 will not alter performanceComparing Summary
|
sansyrox
force-pushed
the
feat/faster-jsonification
branch
from
238577a
to
f5bc367
Compare
Co-authored-by: Jack Thomson <[email protected]>
sansyrox
force-pushed
the
feat/faster-jsonification
branch
from
f5bc367
to
cd56822
Compare
|
@JackThomson2 , see the commit authors 👀 |
|
Nice! What performance uplift did you see? |
|
@JackThomson2 , not a lot tbh 😅 But I believe the real performance benchmarks will be added if we can make use of serde's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #525