[feat]: Added port already in use warning. #558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for robyn pending review.Visit the deploys page to approve it
|
|
@sansyrox I think the feature became a bug for the tests in Windows 😅 . The GHA is running all the tests for windows on the same machine at the same time I guess that is why that port is already in use warning/error is there 🥲 . |
sansyrox
reviewed
Jul 20, 2023
sansyrox
reviewed
Jul 30, 2023
Mr-Sunglasses
force-pushed
the
port-use-patch
branch
from
e6dfe14
to
2c5c843
Compare
|
@sansyrox Fixed all the requested changes. 🕺🏻 |
sansyrox
reviewed
Aug 5, 2023
CodSpeed Performance ReportMerging #558 will not alter performanceComparing Summary
|
sansyrox
force-pushed
the
main
branch
5 times, most recently
from
71f36b6
to
416bc97
Compare
sansyrox
reviewed
Aug 10, 2023
robyn/processpool.py
Outdated
Comment on lines
29
to
32
| except OSError: | ||
| return True | ||
| except Exception: | ||
| return True |
There was a problem hiding this comment.
Hey @Mr-Sunglasses 👋
One suggestion - let us return errors here. It is a recommended way to
not do a generic catch all for the Exception
sansyrox
force-pushed
the
main
branch
2 times, most recently
from
5588625
to
d04fb5e
Compare
|
Hey @Mr-Sunglasses 👋 Any updates on this PR ? |
Mr-Sunglasses
force-pushed
the
port-use-patch
branch
from
6ae6e67
to
2ffd591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added port already in use warning and added to ask the user for the prompt to use the new port.
Description
port-patch.mov
This PR fixes #508, #557