feat: Improved the Current CLI. #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for robyn canceled.
|
sansyrox
reviewed
Jul 18, 2023
shivaylamba
reviewed
Jul 19, 2023
|
Also Fixes #560 |
sansyrox
reviewed
Jul 30, 2023
sansyrox
reviewed
Jul 30, 2023
sansyrox
reviewed
Jul 30, 2023
There was a problem hiding this comment.
Hey @Mr-Sunglasses 👋
Great work! 🔥 I have some minor suggestions. We can merge it after that! ✨
CodSpeed Performance ReportMerging #556 will not alter performanceComparing Summary
|
|
@sansyrox I've made the changes in this PR s requested. Do tell me if any more changes to be made or if not it is ready to merge 🌮 . |
sansyrox
force-pushed
the
main
branch
3 times, most recently
from
026cc08
to
a8cf7f0
Compare
sansyrox
reviewed
Aug 5, 2023
sansyrox
reviewed
Aug 5, 2023
There was a problem hiding this comment.
Hey @Mr-Sunglasses 👋
Thank you for addressing the suggestions. Just two more suggestions before we can merge it 😄
sansyrox
force-pushed
the
main
branch
2 times, most recently
from
71f36b6
to
416bc97
Compare
Mr-Sunglasses
changed the title
|
@sansyrox 🎉 I have removed the --version flag and just realized 🤔 there's no need for it! One can check if Robyn is installed just by typing python3 -m robyn --help. 🚀 I think this PR is now ready to be merged! 💯 |
feat: Improved the current --create flag of robyn cli with new style Update the requirement.txt for new deps in cli fix: Removed some mistaken additon of --version flag in docs [fix]: Updated the link of robyn docs fixed the doc's link Removed --version docs. removed --version flag from CLI removed --version flag from CLI
sansyrox
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: Improved the current --create flag of robyn cli with new style
feat: added the new --version flag in robyn cli to check the currently installed version of robyn
Screen.Recording.2023-07-17.at.4.56.04.AM.mov
This PR fixes #511 (Note - This PR fixes a small portion of issue #511, there is a complete roadmap of features in the issue which need to be added to completely fix this issue )