This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
[fix] Perforce auth provider panics when only IP is provided #64533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re helpful error message
github-actions
bot
added
team/product-platform
team/source
|
Should we clarify this in our docs too? |
mmanela
approved these changes
Aug 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When only an IP address and port (like
127.0.0.1:3080is provided asp4.port, the auth provider will panic since the value can't be parsed as a URL correctly. This is common to do when talking to Perforce, because thep4CLI automatically prefixestcp:if this is the case.However, we can't quite do this because the auth provider URL and the code host URL need to match, so if we auto-adjust the auth provider URL they will no longer match.
This PR adds error handling on the auth provider, and will display a more helpful error message instead of panicking.
Test plan
Unit test added
Changelog