This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Include both the changelist and commit in the query #64501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterguy
commented
Aug 15, 2024
| .then(mapOrThrow(result => result.data?.repository?.commit ?? null)), | ||
| .then( | ||
| mapOrThrow( | ||
| result => result.data?.repository?.changelist?.commit ?? result.data?.repository?.commit ?? null |
There was a problem hiding this comment.
Use the commit from the changelist if it exists. Otherwise, use the top-level commit. Fallback to null
peterguy
commented
Aug 15, 2024
Comment on lines
+4
to
+18
| changelist(cid: $revspec) { | ||
| commit { | ||
| id | ||
| perforceChangelist { | ||
| cid | ||
| canonicalURL | ||
| } | ||
|
|
||
| blob(path: $path) { | ||
| ...DiffViewGitBlob | ||
| } | ||
|
|
||
| ...DiffViewCommit | ||
| } | ||
| } |
There was a problem hiding this comment.
Just copy/paste the commit structure into the changelist structure. One or the other will be populated, depending on the structure of revspec: if it's a CID, then changelist.commit will be populated. If it's a GH hash, then commit will be popultated.
jasonhawkharris
force-pushed
the
jhh/perforce-history-panel
branch
7 times, most recently
from
4faee50
to
c6c654c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rather crude approach, but it works and it gives a suggestion of how to approach a solution.