This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
fix/internal/grpc: retry: add requires-network tag to BUILD.bazel #64196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team/product-platform
team/source
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ggilmore
force-pushed
the
graphite-ggilmorefix_internal_grpc_retry_add_requires-network_tag_to_build.bazel
branch
from
9458e9c
to
23c2dbd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/sourcegraph/issue/SRC-497/data-race-in-internalgrpcretryretry-test-causing-flakiness-on-main
Test plan
sg bazel test //internal/grpc/retry:retry_test --runs_per_test=100 --jobs=1passesran test 10000 times here: https://buildkite.com/sourcegraph/sourcegraph/builds/285449#01910a10-f2d8-43b5-a504-73f1479ee43e
Changelog