Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass id as positional arg to avoid unexpected error on old gym #106

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

ishihara-y
Copy link
Contributor

gym's Envspec uses different arg names among different versions and causes error.
(around ver. 0.23.0. id is named as id_requested)

This PR fixes this issue by passing the id without specifying its name.

Copy link
Contributor

@sbsekiguchi sbsekiguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sbsekiguchi sbsekiguchi merged commit a886b81 into master Aug 21, 2023
11 checks passed
@ishihara-y ishihara-y deleted the feature/20230818-fix-envspec branch December 22, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants