-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgmt|202311: Skip some route tests for standalone topos. #14483
mgmt|202311: Skip some route tests for standalone topos. #14483
Conversation
Some route tests do not apply to standalone topologies and should be skipped. This patch skips such tests.
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Corrected yaml formatting of previous commit.
1823dd8
to
b7d315e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wangxin Please help to merge this PR, thanks |
Description of PR
Summary:
Some route tests do not apply to standalone
topologies and should be skipped. This patch skips such tests.
Corresponding PR was opened, approved, and merged for master and 202405: #13889
Type of change
Back port request
Approach
What is the motivation for this PR?
Some route tests are not applicable to t0 topos and should be skipped rather than failing unecessarily, negatively impacting pass rate.
How did you do it?
Applied skip conditions to the applicable tests in the tests mark conditions yaml file in sonic-mgmt.
How did you verify/test it?
Ran the route test suite and confirmed that the desired tests are now skipped.
Any platform specific information?
Verified on Arista-7060X6-64PE-256x200G.