Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt|202311: Skip some route tests for standalone topos. #14483

Conversation

ccroy-arista
Copy link
Contributor

@ccroy-arista ccroy-arista commented Sep 10, 2024

Description of PR

Summary:

Some route tests do not apply to standalone
topologies and should be skipped. This patch skips such tests.

Corresponding PR was opened, approved, and merged for master and 202405: #13889

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Some route tests are not applicable to t0 topos and should be skipped rather than failing unecessarily, negatively impacting pass rate.

How did you do it?

Applied skip conditions to the applicable tests in the tests mark conditions yaml file in sonic-mgmt.

How did you verify/test it?

Ran the route test suite and confirmed that the desired tests are now skipped.

Any platform specific information?

Verified on Arista-7060X6-64PE-256x200G.

Some route tests do not apply to standalone topologies
and should be skipped. This patch skips such tests.
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Failed
- hook id: check-yaml
- exit code: 1

while constructing a mapping
in "tests/common/plugins/conditional_mark/tests_mark_conditions.yaml", line 1363, column 5
found duplicate key "reason" with value "Does not apply to standalone topos." (original value: "Test not supported for 201911 images or older.")
in "tests/common/plugins/conditional_mark/tests_mark_conditions.yaml", line 1366, column 5

To suppress this check see:
http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys

check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Copy link
Contributor

@Janetxxx Janetxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Corrected yaml formatting of previous commit.
@ccroy-arista ccroy-arista force-pushed the skip-route-tests-for-standalone-topos-202311 branch from 1823dd8 to b7d315e Compare September 10, 2024 16:07
Copy link
Contributor

@Janetxxx Janetxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Janetxxx
Copy link
Contributor

@wangxin Please help to merge this PR, thanks

@StormLiangMS StormLiangMS merged commit 3fefd8d into sonic-net:202311 Sep 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants