[202311] Stabilize PFC watchdog test #14468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This PR is to cherry-pick #14425 to
202311
branch.Changes include
This is because I didn't see improvement using multiple processes to send PFC pause frames when there is only 1 port to be paused. And the multi-processing caused test flakiness in
test_pfcwd_multi_port
Before this change, there was a hard-coded 5 seconds delay. But on some platform (e.g, Mellanox) more time is needed until PFC watchdog is triggered.
Type of change
Back port request
Approach
What is the motivation for this PR?
This PR is to stabilize PFC watchdog test.
How did you do it?
How did you verify/test it?
The change is verified on a Mellanox testbed. All test cases in
pfcwd/test_pfcwd_function.py
are consistently passing now.Any platform specific information?
No.
Supported testbed topology if it's a new test case?
Not a new test case.
Documentation