[wol_test] Test expected failure like invalid parameters, down interface etc. #14387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizhijianrd
reviewed
Sep 3, 2024
| logging.info("Test with random dut port %s and ptf port index %s" % (random_dut_port, random_ptf_port)) | ||
| exception_catched = False | ||
| try: | ||
| duthost.shell("wol %s %s -b -p %s" % (random_dut_port, target_mac, password)) |
There was a problem hiding this comment.
duthost.shell() should be able to return a dict which contains rc and stderr. Why the testcase expect Exception?
There was a problem hiding this comment.
It will raise exception before return dict, so we need to catch the exception.
| ): | ||
| target_mac = "1a:2b:3c:d1:e2:f7" | ||
| connected_dut_intf_to_ptf_index = get_connected_dut_intf_to_ptf_index | ||
| random_dut_port, random_ptf_port = random.choice(connected_dut_intf_to_ptf_index) |
There was a problem hiding this comment.
Since these testcases only check invalid param. I suggest to remove these random variables. Use fixed param to simplify the testcases.
There was a problem hiding this comment.
No problem, but this code can read port info from device and topo file, it's better than fixed port.
lizhijianrd
approved these changes
Sep 3, 2024
|
Hi @wangxin, cloud you help merge this PR? thanks in advance. |
wangxin
approved these changes
Sep 5, 2024
|
Hi @yxieca and @bingwang-ms , cloud you help approve backporting to 202311 and 202405? thanks in advance. |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 6, 2024
…ace etc. (sonic-net#14387) What is the motivation for this PR? Wol has the ability to filter invalid parameters, we need to test this ability. How did you do it? Run wol with invalid parameters and check the output and return code of command. How did you verify/test it? Run on testbed Any platform specific information? Mx topo only.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 6, 2024
…ace etc. (sonic-net#14387) What is the motivation for this PR? Wol has the ability to filter invalid parameters, we need to test this ability. How did you do it? Run wol with invalid parameters and check the output and return code of command. How did you verify/test it? Run on testbed Any platform specific information? Mx topo only.
|
Cherry-pick PR to 202405: #14455 |
|
Cherry-pick PR to 202311: #14456 |
mssonicbld
pushed a commit
that referenced
this pull request
Sep 6, 2024
…ace etc. (#14387) What is the motivation for this PR? Wol has the ability to filter invalid parameters, we need to test this ability. How did you do it? Run wol with invalid parameters and check the output and return code of command. How did you verify/test it? Run on testbed Any platform specific information? Mx topo only.
mssonicbld
added
Included in 202311 branch
and removed
Created PR to 202311 branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Sep 7, 2024
…ace etc. (#14387) What is the motivation for this PR? Wol has the ability to filter invalid parameters, we need to test this ability. How did you do it? Run wol with invalid parameters and check the output and return code of command. How did you verify/test it? Run on testbed Any platform specific information? Mx topo only.
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Sep 20, 2024
…ace etc. (sonic-net#14387) What is the motivation for this PR? Wol has the ability to filter invalid parameters, we need to test this ability. How did you do it? Run wol with invalid parameters and check the output and return code of command. How did you verify/test it? Run on testbed Any platform specific information? Mx topo only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Test expected failure like invalid parameters, down interface etc.
Type of change
Back port request
Approach
What is the motivation for this PR?
Wol has the ability to filter invalid parameters, we need to test this ability.
How did you do it?
Run wol with invalid parameters and check the output and return code of command.
How did you verify/test it?
Run on testbed
Any platform specific information?
Mx topo only.
Supported testbed topology if it's a new test case?
Documentation