[202305] Refactor neighbor VM image downloading #14358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is the motivation for this PR? The original design assumes downloading neighbor VM images from azure storage using SAS key if image file is not found on local testbed server. Since SAS key is considered as a credential, the design introduces complexity of managing SAS keys securely. How did you do it? This change refactored the design to download image files from simple HTTP server. URL of the image files can be specified in variable files under ansible/group_vars/vm_host. How did you verify/test it? Run add-topo/remove-topo, start-topo-vms/stop-topo-vms Signed-off-by: Xin Wang <[email protected]>
lerry-lee
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Manually cherry-pick #14200 to 202305 branch due to conflicts.
Type of change
Back port request
Approach
What is the motivation for this PR?
The original design assumes downloading neighbor VM images from azure storage using SAS key if image file is not found on local testbed server. Since SAS key is considered as a credential, the design introduces complexity of managing SAS keys securely.
How did you do it?
This change refactored the design to download image files from simple HTTP server. URL of the image files can be specified in variable files under ansible/group_vars/vm_host.
How did you verify/test it?
Run add-topo/remove-topo, start-topo-vms/stop-topo-vms
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation