[Feat] Enable recover in the post sanity check #14296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyw233
approved these changes
Aug 29, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 29, 2024
Description of PR Summary: Fixes # (issue) Extract the recover of sanity check failure into a single method, enable sanity check recover in post canity test. Approach What is the motivation for this PR? If the pre sanity check failed, all the test module are marked as failed. With post sanity check, we can kick out the testbed immediately after the test module finished, rather than on the beginning of the next test module. How did you do it? Extract the recover of sanity check failure into a single method, enable sanity check recover in post canity test. How did you verify/test it? On physical testbeds, both the recover of pre/post sanity check works as expected. co-authorized by: [email protected]
|
Cherry-pick PR to 202405: #14329 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 30, 2024
Description of PR Summary: Fixes # (issue) Extract the recover of sanity check failure into a single method, enable sanity check recover in post canity test. Approach What is the motivation for this PR? If the pre sanity check failed, all the test module are marked as failed. With post sanity check, we can kick out the testbed immediately after the test module finished, rather than on the beginning of the next test module. How did you do it? Extract the recover of sanity check failure into a single method, enable sanity check recover in post canity test. How did you verify/test it? On physical testbeds, both the recover of pre/post sanity check works as expected. co-authorized by: [email protected]
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
eddieruan-alibaba
pushed a commit
to eddieruan-alibaba/sonic-mgmt
that referenced
this pull request
Sep 4, 2024
Description of PR Summary: Fixes # (issue) Extract the recover of sanity check failure into a single method, enable sanity check recover in post canity test. Approach What is the motivation for this PR? If the pre sanity check failed, all the test module are marked as failed. With post sanity check, we can kick out the testbed immediately after the test module finished, rather than on the beginning of the next test module. How did you do it? Extract the recover of sanity check failure into a single method, enable sanity check recover in post canity test. How did you verify/test it? On physical testbeds, both the recover of pre/post sanity check works as expected. co-authorized by: [email protected]
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Sep 20, 2024
Description of PR Summary: Fixes # (issue) Extract the recover of sanity check failure into a single method, enable sanity check recover in post canity test. Approach What is the motivation for this PR? If the pre sanity check failed, all the test module are marked as failed. With post sanity check, we can kick out the testbed immediately after the test module finished, rather than on the beginning of the next test module. How did you do it? Extract the recover of sanity check failure into a single method, enable sanity check recover in post canity test. How did you verify/test it? On physical testbeds, both the recover of pre/post sanity check works as expected. co-authorized by: [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Extract the recover of sanity check failure into a single method,
enable sanity check recover in post canity test.
Type of change
Back port request
Approach
What is the motivation for this PR?
If the pre sanity check failed, all the test module are marked as failed.
With post sanity check, we can kick out the testbed immediately after the test module finished, rather than on the beginning of the next test module.
How did you do it?
Extract the recover of sanity check failure into a single method,
enable sanity check recover in post canity test.
How did you verify/test it?
On physical testbeds, both the recover of pre/post sanity check works as expected.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation