Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: temporarily disable orchagent check for BFD test #14261

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

cyw233
Copy link
Contributor

@cyw233 cyw233 commented Aug 27, 2024

Description of PR

As discussed in the last chassis meeting, we want to temporarily disable orchagent CPU check for BFD tests as it is not stable at the moment.

Summary:
Fixes # (issue) Microsoft ADO 29191540

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

I ran the updated BFD tests and confirmed that orchagent check is disabled

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/bfd/conftest.py:7:1: F401 'tests.common.utilities.wait_until' imported but unused
tests/bfd/conftest.py:8:1: F401 'tests.platform_tests.link_flap.link_flap_utils.check_orch_cpu_utilization' imported but unused

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Copy link
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit e440ba0 into sonic-net:master Aug 28, 2024
17 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Aug 28, 2024
)

Description of PR
As discussed in the last chassis meeting, we want to temporarily disable orchagent CPU check for BFD tests as it is not stable at the moment.

Summary:
Fixes # (issue) Microsoft ADO 29191540

Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
I ran the updated BFD tests and confirmed that orchagent check is disabled

co-authorized by: [email protected]
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #14286

mssonicbld pushed a commit that referenced this pull request Aug 30, 2024
Description of PR
As discussed in the last chassis meeting, we want to temporarily disable orchagent CPU check for BFD tests as it is not stable at the moment.

Summary:
Fixes # (issue) Microsoft ADO 29191540

Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
I ran the updated BFD tests and confirmed that orchagent check is disabled

co-authorized by: [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants