Fix flaky test_reload_configuration_checks when all processes are not… #14218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizhijianrd
approved these changes
Aug 23, 2024
|
@tudupa please fix the build errors |
|
/azpw run Azure.sonic-mgmt |
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-mgmt |
|
@tudupa Can you please help comment |
|
/azpw run Azure.sonic-mgmt |
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… up during swss stop job
tudupa
force-pushed
the
platform_tests/test_reload_config
branch
from
4a9fc7e
to
4aaa76c
Compare
wangxin
approved these changes
Aug 28, 2024
|
@bingwang-ms @yxieca Can you please help add approval tag for backport 202405/202311, thank you! |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 28, 2024
… up during swss stop job (sonic-net#14218) What is the motivation for this PR? The testcase test_reload_configuration_checks fails sometimes when swss is stopped after a config reload and some of the critical processes are still coming up. The stop job of swss in the queue is cancelled due to other critical processes still coming up and trying to bring up swss. Hence, we get the error - "Job for swss.service cancelled" How did you do it? This PR enhanced the testcase to wait until all the critical processes are up after a config reload and then execute a stop job for swss. How did you verify/test it? Ran the testcase 15-20 times to see if it fails.
|
Cherry-pick PR to 202405: #14298 |
Merged
8 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 28, 2024
… up during swss stop job (sonic-net#14218) What is the motivation for this PR? The testcase test_reload_configuration_checks fails sometimes when swss is stopped after a config reload and some of the critical processes are still coming up. The stop job of swss in the queue is cancelled due to other critical processes still coming up and trying to bring up swss. Hence, we get the error - "Job for swss.service cancelled" How did you do it? This PR enhanced the testcase to wait until all the critical processes are up after a config reload and then execute a stop job for swss. How did you verify/test it? Ran the testcase 15-20 times to see if it fails.
|
Cherry-pick PR to 202311: #14302 |
Merged
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 28, 2024
… up during swss stop job (#14218) What is the motivation for this PR? The testcase test_reload_configuration_checks fails sometimes when swss is stopped after a config reload and some of the critical processes are still coming up. The stop job of swss in the queue is cancelled due to other critical processes still coming up and trying to bring up swss. Hence, we get the error - "Job for swss.service cancelled" How did you do it? This PR enhanced the testcase to wait until all the critical processes are up after a config reload and then execute a stop job for swss. How did you verify/test it? Ran the testcase 15-20 times to see if it fails.
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Aug 28, 2024
… up during swss stop job (#14218) What is the motivation for this PR? The testcase test_reload_configuration_checks fails sometimes when swss is stopped after a config reload and some of the critical processes are still coming up. The stop job of swss in the queue is cancelled due to other critical processes still coming up and trying to bring up swss. Hence, we get the error - "Job for swss.service cancelled" How did you do it? This PR enhanced the testcase to wait until all the critical processes are up after a config reload and then execute a stop job for swss. How did you verify/test it? Ran the testcase 15-20 times to see if it fails.
mssonicbld
added
Included in 202311 branch
and removed
Created PR to 202311 branch
labels
eddieruan-alibaba
pushed a commit
to eddieruan-alibaba/sonic-mgmt
that referenced
this pull request
Sep 4, 2024
… up during swss stop job (sonic-net#14218) What is the motivation for this PR? The testcase test_reload_configuration_checks fails sometimes when swss is stopped after a config reload and some of the critical processes are still coming up. The stop job of swss in the queue is cancelled due to other critical processes still coming up and trying to bring up swss. Hence, we get the error - "Job for swss.service cancelled" How did you do it? This PR enhanced the testcase to wait until all the critical processes are up after a config reload and then execute a stop job for swss. How did you verify/test it? Ran the testcase 15-20 times to see if it fails.
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Sep 20, 2024
… up during swss stop job (sonic-net#14218) What is the motivation for this PR? The testcase test_reload_configuration_checks fails sometimes when swss is stopped after a config reload and some of the critical processes are still coming up. The stop job of swss in the queue is cancelled due to other critical processes still coming up and trying to bring up swss. Hence, we get the error - "Job for swss.service cancelled" How did you do it? This PR enhanced the testcase to wait until all the critical processes are up after a config reload and then execute a stop job for swss. How did you verify/test it? Ran the testcase 15-20 times to see if it fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… up during swss stop job
Type of change
Back port request
Approach
What is the motivation for this PR?
The testcase test_reload_configuration_checks fails sometimes when swss is stopped after a config reload and some of the critical processes are still coming up. The stop job of swss in the queue is cancelled due to other critical processes still coming up and trying to bring up swss. Hence, we get the error - "Job for swss.service cancelled"
How did you do it?
This PR enhanced the testcase to wait until all the critical processes are up after a config reload and then execute a stop job for swss.
How did you verify/test it?
Ran the testcase 15-20 times to see if it fails.
Any platform specific information?
NA
Supported testbed topology if it's a new test case?
NA