[dualtor] Fix flakiness of route/test_static_route.py #14202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: 1) Adding "setup_standby_ports_on_rand_unselected_tor" fixture to setup ports in standby mode in case of active-active topology. This is needed for packets not to go out of unexpected tor and cause test failures. 2) Test is performing "config_reload", this can cause switchover (active to standy and viceversa). But rand_selected_dut should be in active state for traffic verification to pass, so after config_reload we need to toggle ports to rand_selected_dut.
lolyu
reviewed
Aug 22, 2024
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @lolyu @StormLiangMS Please review the changes. Thanks! |
|
hi @vkjammala-arista there is a conflict, could you help with? |
Resolved the conflict, thanks! |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 19, 2024
* [dualtor] Fix flakiness of route/test_static_route.py Fixes: 1) Adding "setup_standby_ports_on_rand_unselected_tor" fixture to setup ports in standby mode in case of active-active topology. This is needed for packets not to go out of unexpected tor and cause test failures. 2) Test is performing "config_reload", this can cause switchover (active to standy and viceversa). But rand_selected_dut should be in active state for traffic verification to pass, so after config_reload we need to toggle ports to rand_selected_dut. * Addressing review comments. * Reverting minor unintended change.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 19, 2024
* [dualtor] Fix flakiness of route/test_static_route.py Fixes: 1) Adding "setup_standby_ports_on_rand_unselected_tor" fixture to setup ports in standby mode in case of active-active topology. This is needed for packets not to go out of unexpected tor and cause test failures. 2) Test is performing "config_reload", this can cause switchover (active to standy and viceversa). But rand_selected_dut should be in active state for traffic verification to pass, so after config_reload we need to toggle ports to rand_selected_dut. * Addressing review comments. * Reverting minor unintended change.
|
Cherry-pick PR to 202405: #14645 |
|
Cherry-pick PR to 202311: #14646 |
This was referenced Sep 19, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Sep 20, 2024
* [dualtor] Fix flakiness of route/test_static_route.py Fixes: 1) Adding "setup_standby_ports_on_rand_unselected_tor" fixture to setup ports in standby mode in case of active-active topology. This is needed for packets not to go out of unexpected tor and cause test failures. 2) Test is performing "config_reload", this can cause switchover (active to standy and viceversa). But rand_selected_dut should be in active state for traffic verification to pass, so after config_reload we need to toggle ports to rand_selected_dut. * Addressing review comments. * Reverting minor unintended change.
mssonicbld
added
Included in 202311 branch
and removed
Created PR to 202311 branch
labels
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Sep 20, 2024
* [dualtor] Fix flakiness of route/test_static_route.py Fixes: 1) Adding "setup_standby_ports_on_rand_unselected_tor" fixture to setup ports in standby mode in case of active-active topology. This is needed for packets not to go out of unexpected tor and cause test failures. 2) Test is performing "config_reload", this can cause switchover (active to standy and viceversa). But rand_selected_dut should be in active state for traffic verification to pass, so after config_reload we need to toggle ports to rand_selected_dut. * Addressing review comments. * Reverting minor unintended change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fix flakiness of route/test_static_route.py due to packet going to unexpected ToR
Fixes # https://github.com/aristanetworks/sonic-qual.msft/issues/230
Type of change
Back port request
Approach
What is the motivation for this PR?
As part of traffic verification, sometimes packet is going out of wrong ToR and causing test failures with signature something like
AssertionError: Received expected packet on port 30 for device 0, but it should have arrived on one of these ports: [52, 0, 36].Reason being, in case of
dualtor-aa, both the duts will be in active state and packet can go out ofrand_unselected_dut.How did you do it?
setup_standby_ports_on_rand_unselected_torfixture to setup ports in standby mode in case of active-active topology. This is needed for packets not to go out of unexpected tor and cause test failures.rand_selected_dutshould be in active state for traffic verification to pass, so after config_reload weneed to toggle ports to rand_selected_dut.
How did you verify/test it?
Stressed the test on
Arista-7260CX3-D108C8and test is passing.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation