-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to new API from mate-menus 1.21 #103
Conversation
This fixes an issue when Brisk swallows ButtonPress events when window manager is set to Super as its modifier key for moving and resizing windows. Fixes solus-project#96
@raveit65, @monsta, @flexiondotorg, @yetist - please test at your convenience. This update won't really be necessary until we hit 1.22 (unless @ikeydoherty wants to track this against MATE 1.21 dev version) |
This addresses an issue that occurs when trying to close the menu using the configured shortcut without modifiers, but Lock keys (NumLock, etc) are enabled. Fixes solus-project#70
Well, I don't use this menu, so I probably won't be able to test for regressions... |
Looks like it's not finished? If install/uninstall the software, brisk-menu applet will crash. |
This fixes an issue when Brisk swallows ButtonPress events when window manager is set to Super as its modifier key for moving and resizing windows. Fixes solus-project#96
This addresses an issue that occurs when trying to close the menu using the configured shortcut without modifiers, but Lock keys (NumLock, etc) are enabled. Fixes solus-project#70
@yetist - When the
Some of those are deferred because of the monitor callbacks, so maybe I need to explicitly call it earlier? Or am I looking at the wrong thing? Sorry, it's been a while since I touch this code and I honestly don't remember a lot of what I did here 😕 |
In my tests, it working in most cases, the install/uninstall software works. I wrote the following script:
And use |
@yetist - yeah, I can reproduce this consistently. The issue seems to happen when adding the item to the GTK container in gtk_container_add(GTK_CONTAINER(BRISK_CLASSIC_WINDOW(self)->apps), button); It also happens with the |
damn, did I just really do that? sigh... I'll close this and open a new pull request under https://github.com/getsolus/brisk-menu |
I've moved this to getsolus/brisk-menu#2 |
This may be considered work in progress. The mate-menus project has been updated and has breaking API changes. This pull request updates Brisk to support the new API, but until all necessary dependencies have been tagged appropriately (and 1.21 is a dev version), it might not make sense to merge this.
I will update this as necessary.
Fixes #115