Test against Ruby 3.3.2 #5793
Merged
Test against Ruby 3.3.2 #5793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3.3.2 just came out, and there seems to be an issue with the now-included `net-pop` gem. Let's test against 3.3.2 for the time being.
github-actions
bot
added
the
changelog:repository
|
Duplicate of #5788 ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5793 +/- ##
=======================================
Coverage 88.78% 88.78%
=======================================
Files 717 717
Lines 16936 16936
=======================================
Hits 15037 15037
Misses 1899 1899 ☔ View full report in Codecov by Sentry. |
Merged
|
I don't know, the errors I saw were about |
tvdeyen
approved these changes
Jun 14, 2024
|
Both test Ruby 3.3.2, but I will rebase mine |
|
Merged because we need a green test suite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.3.3 just came out, and there seems to be an issue with the now-included
net-popgem. Let's test against 3.3.2 for the time being.See https://stackoverflow.com/questions/78617432/strange-bundle-update-issue-disappearing-net-pop-0-1-2-dependency