Fetch adjustments efficiently from Spree::Order #5790
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit updates the Spree::Order model to improve the efficiency of fetching adjustments. The approach is to use includes(:adjustments) in the association queries. This tells ActiveRecord to preload the adjustments along with the line items or shipments, resulting in a more efficient single database query for each table.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: