SolidusAdmin: Components per Adjustment Source #5789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
admin-adjustment-components
branch
from
651d942
to
58325d1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5789 +/- ##
==========================================
+ Coverage 88.73% 88.78% +0.05%
==========================================
Files 713 717 +4
Lines 16924 16936 +12
==========================================
+ Hits 15017 15037 +20
+ Misses 1907 1899 -8 ☔ View full report in Codecov by Sentry. |
This adds a few components that just display adjustment sources. There
are no visual changes. The improvement I was looking for is to de-couple
the adjustments table from individual source types through dynamic
component lookup:
```
component_name = adjustment.source&.class&.table_name&.singularize
component_key = ["orders/show/adjustments/index/adjustment", component_name].compact.join("/")
render component(component_key).new(adjustment)
```
This allows the `solidus_legacy_promotions` gem to ship with a component
that knows how to render an adjustment source of type
`Spree::PromotionAction` without hardcoding anything in `SolidusAdmin`.
mamhoff
force-pushed
the
admin-adjustment-components
branch
from
58325d1
to
ca574c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few components that just display adjustment sources. There are no visual changes. The improvement I was looking for is to de-couple the adjustments table from individual source types through dynamic component lookup:
This allows the
solidus_legacy_promotionsgem to ship with a component that knows how to render an adjustment source of typeSpree::PromotionActionwithout hardcoding anything inSolidusAdmin.