Use configurable adjustment promotion source types in Thumbnail.for #5781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_core
There's a View Component for rendering icons, and it's got a convenience method for rendering adjustables to adjustments. This uses the `Spree::Config.adjustment_promotion_source_types` configuration option to figure out whether an adjustable needs a megaphone as an icon. With the legacy promotion system extracted, `Spree::PromotionAction` will not necessarily be available.
mamhoff
force-pushed
the
configurable-promotion-thumbnails
branch
from
5bc370a
to
f326ca4
Compare
github-actions
bot
removed
the
changelog:solidus_core
tvdeyen
approved these changes
Jun 7, 2024
jarednorman
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a View Component for rendering icons, and it's got a convenience method for rendering adjustables to adjustments.
This uses the
Spree::Config.adjustment_promotion_source_typesconfiguration option to figure out whether an adjustable needs a megaphone as an icon.With the legacy promotion system extracted,
Spree::PromotionActionwill not necessarily be available.