Skip to content

Commit

Permalink
Ensure draft releases name and tag-name are handled in release scripts
Browse files Browse the repository at this point in the history
  • Loading branch information
elia committed Jan 5, 2024
1 parent 492f5a6 commit e888795
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/update_release_draft.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ jobs:
--update \
--branch ${{ github.ref_name }} \
${{ steps.pipeline_context.outputs.current_diff_source_tag }} \
${{ steps.pipeline_context.outputs.candidate_tag }} \
${{ steps.pipeline_context.outputs.candidate_tag }}
1 change: 1 addition & 0 deletions bin/release/extract-pipeline-context
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,6 @@ context_hash = {
}

warn "~~> Generating context..."
context_hash.each { |k, v| warn "#{k}=#{v}" }

context_hash.each { |k, v| puts "#{k}=#{v}" }
6 changes: 5 additions & 1 deletion bin/release/publish-release
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,8 @@ candidate_tag = ARGV.first

warn "~~> Publishing release draft for #{candidate_tag}..."
release = OCTOKIT.releases('solidusio/solidus').find { _1.name == candidate_tag }
OCTOKIT.update_release(release.url, draft: false)
OCTOKIT.update_release(
release.url,
draft: false,
tag_name: candidate_tag,
)
1 change: 1 addition & 0 deletions bin/release/update-release-draft
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ if update
} || OCTOKIT.create_release(
'solidusio/solidus',
candidate_tag_name,
name: candidate_tag_name,
body: notes,
target_commitish: branch,
draft: true,
Expand Down

0 comments on commit e888795

Please sign in to comment.