Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Change SDK and NuGet selection #20

Merged
merged 4 commits into from
Feb 16, 2020
Merged

Change SDK and NuGet selection #20

merged 4 commits into from
Feb 16, 2020

Conversation

mbhoek
Copy link
Member

@mbhoek mbhoek commented Feb 16, 2020

Selects Core .NET 3.1 SDK using global.json; this fixes the build when using dotnet commands.

To test using .NET 2.1: dotnet test --framework netcoreapp2.1
To test using .NET 3.1: dotnet test --framework netcoreapp3.1

Also attempts to be a solution for #18.

@mbhoek mbhoek changed the title Feature/fix fixture Change SDK and NuGet selection Feb 16, 2020
@mbhoek
Copy link
Member Author

mbhoek commented Feb 16, 2020

Apparently the same issue reported in #18 still occurs.

Removing wildcard selection prevents Tests projects being build in Build step without proper framework selection. Similarly the Pack task wil no longer consider Tests projects. Should also slightly improve build time.
@mbhoek
Copy link
Member Author

mbhoek commented Feb 16, 2020

dotnet pack step still considers Tests projects. Investigate why the 'projects' property is not used.

@mbhoek mbhoek merged commit 61c419b into master Feb 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/fix-fixture branch February 16, 2020 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant