Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated function and component #219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roshansathya
Copy link

removed deprecated ListView and componentWillReceiveProps with FlatList and componentDidUpdate respectively

removed deprecated ListView and componentWillReceiveProps with FlatList and componentDidUpdate respectively
amirulabu pushed a commit to vase/react-native-modal-dropdown that referenced this pull request Jul 22, 2019
@@ -14,6 +14,8 @@ import {
View,
Text,
ListView,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, using your fork since this repo seems like an orphan.

ListView import here should just be removed.

keyExtractor={(_, index) => index.toString()}
renderItem = {({item, index}) => this._renderRow(item, index)}
data={this.props.options}
renderSeparator={renderSeparator || this._renderSeparator}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In FlatList, renderSeparator was changed to ItemSeparatorComponent

@Egizas
Copy link

Egizas commented Dec 14, 2019

Is someone planning to merge this PR?

@@ -88,9 +90,9 @@ export default class ModalDropdown extends Component {
};
}

componentWillReceiveProps(nextProps) {
componentDidUpate(prevProps, prevState){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo here, should be componentDidUpdate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants