Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark as ractor-safe #320

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Mark as ractor-safe #320

wants to merge 1 commit into from

Conversation

mohamedhafez
Copy link

@mohamedhafez mohamedhafez commented Sep 18, 2024 •
edited
Loading

Closes #318

Types of Changes

  • Performance improvement when using nio4r in Ractor, and also for when TruffleRuby can run rb_ext_ractor_safe C-extensions in parallel.

Contribution

  • I tested my changes locally.
    On MacOS 15.0,
    uname -a: Darwin mohameds-mbp.lan 24.0.0 Darwin Kernel Version 24.0.0: Mon Aug 12 20:51:54 PDT 2024; root:xnu-11215.1.10~2/RELEASE_ARM64_T6000 arm64
    Ruby versions: 3.1.6 and 3.3.5
    Results: 112 examples, 0 failures, 2 pending
  • I agree to the Developer's Certificate of Origin 1.1.

STILL REQUIRED:

  • someone with more comfort with C-extensions to review if any global state is used and if the extension really is already fully Ractor-safe
  • Possibly add tests for changes? Might be hard to test for concurrency issues

@mohamedhafez mohamedhafez mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make C-extension Ractor-safe
1 participant
@mohamedhafez