JRuby supports Java 8 and higher. Need to emit Java 8 classfile format #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the reason why I changed this is because it was emitting warnings, but I don't have access to my computer in New Zealand to test as there was a power cut and my desktop shut down (I don't know why it didn't reboot). I'm happy to merge this, but I can't release it until I'm back in New Zealand in about a week. |
ioquatix
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JRuby supports Java 8 and higher. Need to emit Java 8 classfile format. Addresses #316
Types of Changes
Contribution
This reverts a change from this last April. Unless there is some GHA action or gem release issue nothing should change other than the classfile format that Java uses to write out its bytecode.