Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds output address setting to DLA.py #22

Merged
merged 2 commits into from
May 8, 2024
Merged

Adds output address setting to DLA.py #22

merged 2 commits into from
May 8, 2024

Conversation

vilukissa68
Copy link
Collaborator

Enables "hidden register" 5c which is used for setting the output address for the DLA.
Includes accumulated minor fixes and changes.

@vilukissa68 vilukissa68 mentioned this pull request May 6, 2024
Merged
hegza
hegza requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@hegza hegza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes.

I'm assuming behavior is tested correct. We might want to review this more holistically at some point but I'm thinking it looks pretty good, considering available tooling.

vp/devel/python_peripherals/DLA.py Outdated Show resolved Hide resolved
vp/devel/python_peripherals/DLA.py Outdated Show resolved Hide resolved
vp/devel/python_peripherals/DLA.py Outdated Show resolved Hide resolved
vp/devel/python_peripherals/DLA.py Show resolved Hide resolved
vp/devel/python_peripherals/DLA.py Outdated Show resolved Hide resolved
vp/devel/python_peripherals/DLA.py Outdated Show resolved Hide resolved
@vilukissa68 vilukissa68 requested a review from hegza May 8, 2024 08:00
hegza
hegza approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@hegza hegza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good enough. Let's do a more holistic review of the VP later.

@vilukissa68 vilukissa68 merged commit 8589089 into soc-hub-fi:main May 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hegza hegza hegza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vilukissa68 @hegza