Simplify output #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's finish up with #7, and then I'll review a revised version of this.
…On Fri, Aug 2, 2019, 9:31 PM Luis Pedro Coelho ***@***.***> wrote:
This builds on #7 <#7> and
adds one more commit that is a pure refactor. I find this version cleaner
as it avoids repeating logic and building and deconstructing Maybe
objects, but it is not a bug, so I separated it to make it easier to accept
#7 <#7> (which is a bona
fides bug fix) without getting into a discussion about style.
------------------------------
You can view, comment on, or merge this pull request online at:
#8
Commit Summary
- Add buggy test case
- TST Futher failing test
- Fix handling of files with multiple streams
- RFCT Simplify output functions
File Changes
- *M* ChangeLog.md
<https://github.com/snoyberg/bzlib-conduit/pull/8/files#diff-0> (3)
- *M* src/Data/Conduit/BZlib.hs
<https://github.com/snoyberg/bzlib-conduit/pull/8/files#diff-1> (70)
- *A* test/sample4.bz2
<https://github.com/snoyberg/bzlib-conduit/pull/8/files#diff-2> (0)
- *A* test/sample4.ref
<https://github.com/snoyberg/bzlib-conduit/pull/8/files#diff-3>
(11088)
- *A* test/sample5.bz2
<https://github.com/snoyberg/bzlib-conduit/pull/8/files#diff-4> (0)
- *A* test/sample5.ref
<https://github.com/snoyberg/bzlib-conduit/pull/8/files#diff-5> (0)
- *M* test/test.hs
<https://github.com/snoyberg/bzlib-conduit/pull/8/files#diff-6> (3)
Patch Links:
- https://github.com/snoyberg/bzlib-conduit/pull/8.patch
- https://github.com/snoyberg/bzlib-conduit/pull/8.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8?email_source=notifications&email_token=AAAMCBY52MYEDQOO25Q43NLQCR4Q3A5CNFSM4IJACKZ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HDD25EA>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAMCB6BS2VMXNOFHEWQKB3QCR4Q3ANCNFSM4IJACKZQ>
.
|
luispedro
force-pushed
the
simplify_output
branch
from
6e979f6
to
c519c52
Compare
Both call sites for the previous function were deconstructing its results in the same way, it is simpler to merge the behaviour into a single function
luispedro
force-pushed
the
simplify_output
branch
from
c519c52
to
b66df11
Compare
|
This is now up-to-date wrt |
snoyberg
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #7 and adds one more commit that is a pure refactor. I find this version cleaner as it avoids repeating logic and building and deconstructing
Maybeobjects, but it is not a bug, so I separated it to make it easier to accept #7 (which is a bona fides bug fix) without getting into a discussion about style.