-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare Unified codebase for Spark ( Iceberg ) Support #77
Prepare Unified codebase for Spark ( Iceberg ) Support #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just like for utils, leaving some comments for clarification, nothing else sticks out for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tentative approval, same as with utils, let's agree on the incremental_stategy (be explicit or permissive) for the release and also investigate why bigquery / redshift started failing. Most likely not related to the spark prep (utils was not linked to the branch for redshift at least) hence the ok for now.
b53d0a7
into
Release/snowplow-unified/0.5.0
Description
QUALIFY
clause with PostgreSQL-compatible logic to ensure consistent behavior across different target types.CAST(x AS data_type)
for Spark compatibility.ROW_NUMBER()
in tests to account for Spark's non-deterministic behavior.What type of PR is this? (check all applicable)
Related Tickets & Documents
Checklist
Added tests?
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?