Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISO-639-2 and ISO-639-3 language mapping codes #76

Merged
merged 7 commits into from
Sep 9, 2024

Conversation

miike
Copy link

@miike miike commented Aug 5, 2024

Description

This adds language mappings for ISO-639-2/T and ISO-639-3 to their respective language codes which are emitted by the mobile trackers.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Checklist

  • 💣 Is your change a breaking change?
  • 📖 I have updated the CHANGELOG.md

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 internal package docs (ymls, macros, readme, if applicable)
  • 📕 I have raised a Snowplow documentation PR if applicable (Link here)
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@miike miike requested a review from a team as a code owner August 5, 2024 03:23
@ilias1111 ilias1111 changed the base branch from main to Release/snowplow-unified/0.5.0 August 14, 2024 12:23
@ilias1111
Copy link
Collaborator

@miike does that solution makes sense to you?

@miike
Copy link
Author

miike commented Sep 9, 2024

Looks good to me! 👍

@ilias1111 ilias1111 merged commit 1a3402e into Release/snowplow-unified/0.5.0 Sep 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants