Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use --password-store=basic when launching Signal #321

Merged
merged 2 commits into from
Oct 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions snap/local/usr/bin/signal-desktop-wrapper
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,21 @@ set -euo pipefail
tray_icon="$(snapctl get tray-icon)"

# Define an array of command line options
opts=()
opts=(
# Don't run the chrome sandbox inside the snap environment, rely on AppArmor confinement
"--no-sandbox"
# See https://github.com/snapcrafters/signal-desktop/issues/300
# An upstream Chrome issue blocks the correct inovation of libsecret from within
# snap/flatpak environments, which means that Signal loses access to the encryption
# key used to encrypt the local database, and needs to be re-linked (losing all message
# history) every time it's launched.
"--password-store=basic"
)

# If the the tray icon is enabled, add to the list of command line args
if [[ "${tray_icon}" == "true" ]]; then
opts+=("--use-tray-icon")
fi

# Run signal-desktop with the gathered arguments
exec "${SNAP}/opt/Signal/signal-desktop" "--no-sandbox" "${opts[@]}" "$@"
exec "${SNAP}/opt/Signal/signal-desktop" "${opts[@]}" "$@"
1 change: 0 additions & 1 deletion snap/snapcraft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@ apps:
- removable-media
- unity7
- screen-inhibit-control
- password-manager-service
environment:
TMPDIR: $XDG_RUNTIME_DIR
# Included temporarily until https://github.com/snapcore/snapcraft-desktop-integration/issues/28
Expand Down
Loading