Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DF-20372 (pt 2): Update Streams PluginConfig checks and FeedID parsing #14504

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

austinborn
Copy link
Collaborator

@austinborn austinborn commented Sep 19, 2024

DF-20372

Three changes are included here:

  • Update logic to check contents of Streams PluginConfig to determine whether to access the Mercury server (previously it just checked PluginConfig == nil but the correct check is len(PluginConfig) == 0, see Added check to not fetch mercury prices when trigger capability is enabled #13888 for the original change.
  • Fix potential nil pointer references for LinkFeedID and NativeFeedID since this was not properly tested in previous change.
  • Update the Feed ID parsing to fetch versions for a new spec for feed IDs prefixed with 0x01 instead of 0x00.

@austinborn austinborn requested review from a team as code owners September 19, 2024 21:09
@austinborn austinborn requested review from krehermann and removed request for a team September 19, 2024 21:09
@austinborn
Copy link
Collaborator Author

Aside from a linting error I just fixed, the remaining checks appear to be failing due to network connection issues:

Error: ../../hashicorp/[email protected]/grpc_broker.go:21:2: github.com/oklog/[email protected]: Get "https://proxy.golang.org/github.com/oklog/run/@v/v1.0.0.mod": stream error: stream ID 7; PROTOCOL_ERROR
Error: Process completed with exit code 1.

@austinborn austinborn force-pushed the fix/streams-keystone-job-acceptance branch from 5673e4d to 0b36185 Compare September 19, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant