Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wasm spec factory #14458

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Add wasm spec factory #14458

wants to merge 8 commits into from

Conversation

nolag
Copy link
Contributor

@nolag nolag commented Sep 17, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@nolag nolag force-pushed the rtinianov_delegateWorkflowSpec branch from b581fa6 to 99206f6 Compare September 17, 2024 13:59
@nolag nolag force-pushed the rtinianov_wasmDelegate branch 3 times, most recently from d2b7b4c to a6ee8f6 Compare September 17, 2024 14:29
Base automatically changed from rtinianov_delegateWorkflowSpec to develop September 17, 2024 20:03
@nolag nolag marked this pull request as ready for review September 18, 2024 15:57
@nolag nolag requested review from a team, eutopian and yevshev as code owners September 18, 2024 15:57
@nolag nolag requested review from krehermann and removed request for a team September 18, 2024 15:57
nolag
nolag commented Sep 19, 2024
View reviewed changes
core/services/job/wasm_file_spec_factory.go
"github.com/smartcontractkit/chainlink/v2/core/logger"
)

type WasmFileSpecFactory struct{}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For visibility to reviewers:

In a side-channel discussion with Cedric, he mentioned that he thinks this should support URLs as well.

I commented that I thought by the time the workflow runs, it would have already ensured that the file is on the box locally. I was thinking that if it needs to use HTTP to fetch the file, that could be done just once. The HTTP invoker could have a deterministic location to save the workflow file. It could then check if the file exists and download it if it doesn’t. Once the file is on disk, it would invoke the WASM file spec.

I’m open to hearing what others think as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other potential use case, if we end up having any pre-build WASMs that users can run by providing their own config, we could leave them in fixed locations

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eutopian eutopian Awaiting requested review from eutopian eutopian is a code owner

@yevshev yevshev Awaiting requested review from yevshev yevshev is a code owner

@krehermann krehermann Awaiting requested review from krehermann krehermann is a code owner automatically assigned from smartcontractkit/foundations

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nolag