remove Solidity Review issue from changeset to test creation of new one

smartcontractkit · Sep 13, 2024 · 74c0601 · 74c0601
1 parent 2b6ab5c
commit 74c0601
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/.github/scripts/jira/enforce-jira-solidity-review.ts b/.github/scripts/jira/enforce-jira-solidity-review.ts
@@ -442,7 +442,7 @@ ${SOLIDITY_REVIEW_PREFIX}PROJ-1234`)
    */
   function assertChecklistCount(checklistJSON: any, minChecklistCount: number) {
     if (checklistJSON.checklists) {
-      if (checklistJSON.checklists instanceof Array && (checklistJSON.checklists as Array<any>).length < minChecklistCount) {
+      if (!(checklistJSON.checklists instanceof Array) || (checklistJSON.checklists as Array<any>).length < minChecklistCount) {
         core.debug('Checklist JSON:')
         core.debug(JSON.stringify(checklistJSON))
         throw new Error(`Checklist JSON either did not contain "checklists" array or it's lenght was smaller than ${minChecklistCount}`)

diff --git a/contracts/.changeset/wet-monkey-signs.md b/contracts/.changeset/wet-monkey-signs.md
@@ -4,6 +4,4 @@
 
 #internal test whether Solidity Review issue enforcement is working
 
-PR issue: TT-1624
-
-Solidity Review issue: TT-1649
+PR issue: TT-1624