Skip to content

Commit

Permalink
Updating SkupperPodmanSite.Status to check if site.AuthMode is internal
Browse files Browse the repository at this point in the history
Fixes #1389
  • Loading branch information
Karen-Schoener committed Apr 24, 2024
1 parent a1c5dd9 commit 5d04831
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
4 changes: 3 additions & 1 deletion cmd/skupper/skupper_podman_site.go
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,9 @@ func (s *SkupperPodmanSite) Status(cmd *cobra.Command, args []string) error {

if site.EnableFlowCollector {
statusOutput.ConsoleUrl = site.GetConsoleUrl()
statusOutput.Credentials = formatter.PlatformSupport{"podman volume", "'skupper-console-users'"}
if site.AuthMode == "internal" {
statusOutput.Credentials = formatter.PlatformSupport{"podman volume", "'skupper-console-users'"}
}
}

if verboseStatus {
Expand Down
5 changes: 2 additions & 3 deletions pkg/utils/formatter/status.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,12 @@ func PrintStatus(data StatusData) error {
fmt.Println()

if len(data.ConsoleUrl) > 0 {
fmt.Println("The site console url is: ", data.ConsoleUrl)
fmt.Printf("The site console url is: %s\n", data.ConsoleUrl)
if len(data.Credentials.SupportName) > 0 {
fmt.Printf("The credentials for internal console-auth mode are held in %s: %s", data.Credentials.SupportType, data.Credentials.SupportName)
fmt.Printf("The credentials for internal console-auth mode are held in %s: %s\n", data.Credentials.SupportType, data.Credentials.SupportName)
}
}

fmt.Println()
return nil
}

Expand Down

0 comments on commit 5d04831

Please sign in to comment.