Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor cleanup #764

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tac0turtle
Copy link

@tac0turtle tac0turtle commented Sep 19, 2024

this pr removes some sdk.Context usage as its not needed. It also preps migration for 52/v2

happy to reduce scope. just saw some cleanup while reading the code

@aljo242
Copy link
Contributor

aljo242 commented Sep 19, 2024

test failing is just a flaky test we will be fixing

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.04%. Comparing base (676a090) to head (2d7c08b).

Files with missing lines Patch % Lines
x/oracle/keeper/grpc_query.go 66.66% 1 Missing ⚠️
x/oracle/keeper/keeper.go 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
- Coverage   57.07%   57.04%   -0.04%     
==========================================
  Files         208      208              
  Lines       11625    11618       -7     
==========================================
- Hits         6635     6627       -8     
- Misses       4387     4388       +1     
  Partials      603      603              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tac0turtle
Copy link
Author

What's the process to get this merged? Anything I have to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants