Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

successfully changed the Level-1/code.yml #69

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

Debshibraj123
Copy link
Contributor

@Debshibraj123 Debshibraj123 commented Jan 21, 2024

Summary

Changes

Closes:

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

@jkcso
Copy link
Collaborator

jkcso commented Jan 21, 2024

@dduzgun-security What do you think?

Copy link
Contributor

@dduzgun-security dduzgun-security left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good if we keep the permissions section since it restricts the default GITHUB_TOKEN permission used in the GitHub Action to only contents: read.

Copy link
Contributor

@dduzgun-security dduzgun-security left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to remove the Check out code step here. It would be nice to mention it as an item below in the Solution Explanation. Maybe something like: # 7. Think about removing unnecessary steps in the GitHub Actions.

Note

In this example the checkout step copies the code in a GitHub runner but we actually don't need that step to run a simple curl. Removing it reduces the code of being copied (gain in time) and therefore reduces the potential risk of code exposure if an attacker has access to the runner or finds a way to exploit the actions/checkout GitHub Action (gain in security).

@jkcso
Copy link
Collaborator

jkcso commented Jan 22, 2024

Thank you @dduzgun-security, feel free to suggest code + solution additions in the PR, make sure that you test too and I will review at the end to accept :-) Thanks!

@dduzgun-security
Copy link
Contributor

👋 Hey @Debshibraj123, what do you think about the requested changes? I would have loved to suggest code change but it doesn't allow on removed lines of code.

@heiskr heiskr requested a review from jkcso March 25, 2024 15:44
@jkcso
Copy link
Collaborator

jkcso commented Mar 25, 2024

@Debshibraj123 any updates here please?

@nxhettry
Copy link

nxhettry commented Apr 6, 2024

Guys i am a beginner, this suddenly appeared in my pull request. What is this? Someone tell me.

@nxhettry
Copy link

nxhettry commented Apr 6, 2024

What are these comments and commits related to?

@jkcso
Copy link
Collaborator

jkcso commented Apr 7, 2024

@nxhettry don't worry my friend, nothing to do here for you

@dduzgun-security
Copy link
Contributor

@jkcso If that sounds good with you, let's merge this and I'll address the comment in another PR

Co-authored-by: Deniz Onur Duzgun <[email protected]>
@jkcso jkcso merged commit 1b874fe into skills:main Apr 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants