Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix x-axis label collision #4269

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix x-axis label collision #4269

merged 2 commits into from
Sep 10, 2024

Conversation

4nshuman
Copy link
Contributor

@4nshuman 4nshuman commented Sep 8, 2024

This PR resolves : Issue#2761

Before :
image

After :
image

Your checklist for a pull request to sitespeed.io

Please review the guidelines for contributing to this repository.

  • I'm making a big change or adding functionality so I've already opened an issue proposing the change to other contributors, so I got feedback on the idea before took the time to write precious code
  • Check that your change/fix has corresponding unit tests (if applicable)
  • Squash commits so it looks sane
  • Update the documentation https://github.com/sitespeedio/sitespeed.io/tree/main/docs in another PR
  • Verify that the test works by running npm test and test linting by npm run lint

Description

Please describe your pull request and tell us the fix #

Thank you for making sitespeed.io even better!

@4nshuman 4nshuman changed the title Issue/2761 fix x-axis label collision Sep 8, 2024
@soulgalore
Copy link
Member

Hi @4nshuman thanks for the PR! Sorry for not getting back earlier, I'm gonna test it out later today. Thanks again!

@soulgalore soulgalore merged commit 63ea22f into sitespeedio:main Sep 10, 2024
7 of 9 checks passed
@soulgalore
Copy link
Member

Thank you @4nshuman for the fix!

@4nshuman
Copy link
Contributor Author

Hey @soulgalore , could you please assign this PR and the Issue to me so that is shows up on my Git feed.
Thanks !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

html report visualmetrics times overlap
2 participants