Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker compose: grammar fix #3896

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Docker compose: grammar fix #3896

merged 3 commits into from
Jul 7, 2023

Conversation

Amerousful
Copy link
Contributor

It's a not big deal, but I decided to fix it.

@Amerousful
Copy link
Contributor Author

Amerousful commented Jul 3, 2023 •
edited
Loading

Crux check was failed.
bin/sitespeed.js -b chrome -n 1 --crux.key https://en.wikipedia.org/wiki/Main_Page --plugins.remove browsertime
Does instance have secrets.CRUX_KEY?

@soulgalore
Copy link
Member

Hi @Amerousful thanks, that key doesn't work for contributors, that's annoying, I wonder if there's a way to fix that.

@soulgalore soulgalore merged commit 6f111bc into sitespeedio:main Jul 7, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amerousful @soulgalore