Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for python 3.11 #249

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ orbs:
executors:
tap_tester:
docker:
- image: 218546966473.dkr.ecr.us-east-1.amazonaws.com/circle-ci:stitch-tap-tester
- image: 218546966473.dkr.ecr.us-east-1.amazonaws.com/circle-ci:stitch-tap-tester-3-11-dev
jobs:
ensure_env:
executor: tap_tester
Expand All @@ -17,7 +17,7 @@ jobs:
aws s3 cp s3://com-stitchdata-dev-deployment-assets/environments/tap-tester/tap_tester_sandbox /usr/local/share/virtualenvs/dev_env.sh
python3 -m venv /usr/local/share/virtualenvs/tap-hubspot/
source /usr/local/share/virtualenvs/tap-hubspot/bin/activate
pip install -U 'pip<19.2' 'setuptools<51.0.0'
pip install -U pip 'setuptools<51.0.0'
pip install .[dev]
- persist_to_workspace:
root: /usr/local/share/virtualenvs/
Expand All @@ -37,19 +37,16 @@ jobs:
- run:
name: 'pylint'
command: |
source /usr/local/share/virtualenvs/dev_env.sh
source /usr/local/share/virtualenvs/tap-hubspot/bin/activate
# BUG https://jira.talendforge.org/browse/TDL-15447
echo "Disabling the following $PYLINT_DISABLE_LIST"
pylint tap_hubspot -d "$PYLINT_DISABLE_LIST"
pylint tap_hubspot -d 'broad-except,broad-exception-caught,broad-exception-raised,chained-comparison,empty-docstring,fixme,invalid-name,line-too-long,missing-class-docstring,missing-function-docstring,missing-module-docstring,no-else-raise,no-else-return,too-few-public-methods,too-many-arguments,too-many-branches,too-many-lines,too-many-locals,ungrouped-imports,wrong-spelling-in-comment,wrong-spelling-in-docstring,consider-using-f-string,logging-fstring-interpolation,wrong-import-order,inconsistent-return-statements'
- run:
name: 'Unit Tests'
command: |
source /usr/local/share/virtualenvs/tap-hubspot/bin/activate
nosetests tap_hubspot/tests
pip install coverage
nosetests --with-coverage --cover-erase --cover-package=tap_hubspot --cover-html-dir=htmlcov tap_hubspot/tests/unittests
coverage html
pip install nose2 parameterized nose2[coverage_plugin]>=0.6.5
nose2 --with-coverage -v -s tap_hubspot/tests/unittests
- store_test_results:
path: test_output/report.xml
- store_artifacts:
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 2.14.0
* Updates to run on python 3.11.7 [#249](https://github.com/singer-io/tap-hubspot/pull/249mag)

## 2.13.2
* Fix out-of-index error [#253](https://github.com/singer-io/tap-hubspot/pull/253)

Expand Down
10 changes: 5 additions & 5 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,22 @@
from setuptools import setup

setup(name='tap-hubspot',
version='2.13.2',
version='2.14.0',
description='Singer.io tap for extracting data from the HubSpot API',
author='Stitch',
url='http://singer.io',
classifiers=['Programming Language :: Python :: 3 :: Only'],
py_modules=['tap_hubspot'],
install_requires=[
'attrs==16.3.0',
'singer-python==5.13.0',
'requests==2.20.0',
'backoff==1.8.0',
'singer-python==6.0.0',
'requests==2.31.0',
'backoff==2.2.1',
'requests_mock==1.3.0',
],
extras_require= {
'dev': [
'pylint==2.5.3',
'pylint==3.0.3',
'nose==1.3.7',
]
},
Expand Down
2 changes: 1 addition & 1 deletion tap_hubspot/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -1312,7 +1312,7 @@ def load_shared_schema_refs():

shared_schema_refs = {}
for shared_file in shared_file_names:
with open(os.path.join(shared_schemas_path, shared_file)) as data_file:
with open(os.path.join(shared_schemas_path, shared_file), encoding='UTF=8') as data_file:
shared_schema_refs[shared_file] = json.load(data_file)

return shared_schema_refs
Expand Down