Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ads.creative.creative_id in favor of ads.creative.id #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove ads.creative.creative_id in favor of ads.creative.id #113

wants to merge 1 commit into from

Conversation

cosimon
Copy link
Contributor

@cosimon cosimon commented Nov 12, 2020

Description of change

ads.creative.creative_id is not returned by the facebook api, so remove it from the schema. ads.creative.id is the id of the creative on the ad.

Manual QA steps

Risks

  • Potential for customers with old versions of facebook ads in which this is returned. This field has been around since the creation of the tap.

Rollback steps

  • revert this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cosimon