Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #734

Merged
merged 5 commits into from
Mar 1, 2024

Conversation

tommy-mitchell
Copy link
Collaborator

@tommy-mitchell tommy-mitchell commented Feb 29, 2024

Also updates CI version matrix and removes some extraneous TODO comments from #689.

There was some leftover logic for the npm collaborators test that was used for verifying it worked between npm v8 and v9 - it's been removed since we don't support v8 anymore.

Closes #714.

test.skip('external registry', createFixture, [{
command: `${accessCommand()} --registry http://my-internal-registry.local`,
stdout: collaboratorsStdout,
}], async ({t, testedModule: {collaborators}}) => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is behaving weirdly. It's passing, but afterwards it hangs and causes the test file to timeout.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AVA 6 changed to no longer force exit the process at the end, which may be related.

@sindresorhus sindresorhus merged commit aa03498 into sindresorhus:main Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants