fix(arktype): export on model to arktype #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BalogunofAfrica Hi, thanks for the PR (and sorry for the delay on this) Everything looks good here. However I did note there appears to be an issue https://sinclairzx81.github.io/typebox-workbench/ when inferring the type from a ark scope. I've tried updating monaco to the latest version (getting a newer version of the compiler running) but still having problems, so not too sure there. Will merge this through anyway as the updates here are correct and inline with arktype 2.x (meaning the generation is correct). Will chase up monaco configurations on the Workbench project later :) Good work! CC @ssalbdivad |
Merged
|
@BalogunofAfrica Hiya Updates published on 0.10.4. Can previous them https://sinclairzx81.github.io/typebox-workbench/ Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
compilemethod on thescopeobject has been renamed toexportin newer versions (2.x.x) ofarktype.